Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add api level VanillaIceCream support #378

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Add api level VanillaIceCream support #378

merged 1 commit into from
Feb 17, 2024

Conversation

yujincheng08
Copy link
Contributor

No description provided.

ychescale9
ychescale9 reviewed Feb 17, 2024
View reviewed changes
Copy link
Member

@ychescale9 ychescale9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you also run npm run build and check in the changed js file?

src/input-validator.ts Outdated Show resolved Hide resolved
@ychescale9 ychescale9 merged commit d8da5b6 into ReactiveCircus:main Feb 17, 2024
6 of 7 checks passed
@yujincheng08 yujincheng08 deleted the patch-1 branch February 17, 2024 23:20
@RodrigoCMoraes RodrigoCMoraes mentioned this pull request Apr 18, 2024
Closed
@JoseAlcerreca
Copy link

Any chance of releasing a new version with this change?

ychescale9 added a commit that referenced this pull request May 24, 2024
@ychescale9
Merge branch 'main' into release/v2
77986be 
* main:
  Prepare for release 2.31.0.
  Install platforms for the specified api level (#384)
  Add api level `VanillaIceCream` support (#378)
  Bump Gradle wrapper validation from v1 to v2 to use Node 20 (#374)
  Migrate to Node 20 on CI via GitHub Actions major upgrades (#372)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ychescale9 ychescale9 Awaiting requested review from ychescale9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yujincheng08 @JoseAlcerreca @ychescale9